This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: allow reactify callbacks to access props #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 94 94
Lines 1165 1165
Branches 281 281
=======================================
Hits 1164 1164
Partials 1 1
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 491ec3e |
kristw
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed so that the callbacks passed into this component can perform actions based on props/state on the react component
@xtinec @kristw @williaster