-
Notifications
You must be signed in to change notification settings - Fork 272
feat: include control panel in the chart plugin #203
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 99.91% 99.91% +<.01%
==========================================
Files 101 102 +1
Lines 1215 1222 +7
Branches 292 293 +1
==========================================
+ Hits 1214 1221 +7
Partials 1 1
Continue to review full report at Codecov.
|
Deploy preview for superset-ui ready! Built with commit 5bfa3dc |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
af1e1d0
to
357a3c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! LGTM 🚢
357a3c0
to
5bfa3dc
Compare
🏆 Enhancements
ChartControlPanelRegistry
.controlPanel
as part of theChartPlugin
.