Rename ColorScheme field 'name' to 'id'

[kristw]

💔 Breaking Changes

BREAKING CHANGE: Rename ColorScheme field 'name' to 'id'

// from
new CategoricalColorScheme({ name: 'rgb', label: 'rgb colors', colors: ['red', 'green', 'blue']});
// to
new CategoricalColorScheme({ id: 'rgb', label: 'rgb colors', colors: ['red', 'green', 'blue']});

This was inspired by recent discussion in number-format PR #31 that it is confusing to have both name and label and the field name should indicate a bit more uniqueness.

[codecov]

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          48     48           
  Lines         407    407           
=====================================
  Hits          407    407

Impacted Files	Coverage Δ
...et-ui-color/src/colorSchemes/categorical/airbnb.js	100% <ø> (ø)	⬆️
...et-ui-color/src/colorSchemes/categorical/google.js	100% <ø> (ø)	⬆️
...perset-ui-color/src/colorSchemes/categorical/d3.js	100% <ø> (ø)	⬆️
...uperset-ui-color/src/colorSchemes/sequential/d3.js	100% <ø> (ø)	⬆️
...rset-ui-color/src/colorSchemes/categorical/lyft.js	100% <ø> (ø)	⬆️
...set-ui-color/src/colorSchemes/sequential/common.js	100% <ø> (ø)	⬆️
packages/superset-ui-color/src/ColorScheme.js	100% <100%> (ø)	⬆️
...superset-ui-color/src/CategoricalColorNamespace.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8008606...7cfbb4d. Read the comment docs.

[williaster]

LGTM! I agree this is better, one other spot that could be changed is the storybook ... it wouldn't break but now references a field that doesn't exist.