This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Rename D3Formatter to D3NumberFormatter
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 407 408 +1
=====================================
+ Hits 407 408 +1
Continue to review full report at Codecov.
|
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
* fix: pie chart exception * fix: incoporate krist's feedbacl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
fix: Rename
D3FormattertoD3NumberFormatterto avoid ambiguity and naming collision withD3TimeFormatter.Not really breaking change because
@superset-ui/number-formathas not been published yet.