feat: improve world map colors

[mistercrunch]

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/h0syolcfc
✅ Preview: https://superset-ui-git-improveworldmap.superset.vercel.app

[ktmud]

@superset-ui/* packages are normally peerDependencies

[mistercrunch]

ooops

[ktmud]

Close and reopen to trigger CI

[codecov]

Codecov Report

Merging #711 into master will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
+ Coverage   24.19%   24.30%   +0.11%     
==========================================
  Files         339      339              
  Lines        7617     7759     +142     
  Branches      925      961      +36     
==========================================
+ Hits         1843     1886      +43     
- Misses       5701     5789      +88     
- Partials       73       84      +11     

Impacted Files	Coverage Δ
...gins/legacy-plugin-chart-world-map/src/WorldMap.js	0.00% <0.00%> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js	0.00% <0.00%> (ø)
packages/superset-ui-style/src/index.ts	100.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js	0.00% <0.00%> (ø)
...legacy-plugin-chart-sunburst/src/transformProps.js	0.00% <0.00%> (ø)
plugins/plugin-chart-table/src/TableChart.tsx	59.13% <0.00%> (+3.29%)	⬆️
...ins/plugin-chart-table/src/DataTable/DataTable.tsx	56.75% <0.00%> (+9.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c28e93...3445ada. Read the comment docs.

[mistercrunch]

@ktmud unclear why merging is blocked despite Will's approval. Looking to merge this.

Side-thought: wondering if we want to proxy some sort of "utils" to make sure core visualizations are aligned on the version of d3 and lodash that they bring in, or using peerdependecies for this as well?

I'm just afraid that many visualization would depend on misaligned pinned versions of commonly used libs and bloat the bundles sizes.

[ktmud]

@mistercrunch Agreed we should probably have a proxy for the common libraries. d3 could be included, not sure about lodash though (since many lodash functions have easy alternatives in esnext).

[mistercrunch]

I hate to introduce yet another package superset-ui-utils or the like, I wonder if there's a way to generate a common package-lock.json from many package.json.

Probably premature optimization... I'd be curious to see how many versions of d3-* we end up with currently.

[ktmud]

generate a common package-lock.json from many package.json.

That's what monorepo is used for. We do have only one package-lock.json (or rather yarn.lock) in superset-ui, but it's still possible to have many version of d3 packages if not all plugins are updated at the same time. Currently it's relatively easy to update them all since all core plugins live in the same repo---you just search "d3.*": in package.json, sync the versions, and fix any potential backward compatibility issues.

In the async plugin world, we won't be able to control which libraries users bundle into their plugin, but we can provide this proxy to common libraries as part of the plugin API so plugins can reuse the libraries shipped with Superset (ECharts, D3, AntD, etc) and load faster.

[mistercrunch]

Nice! I didn't know the monorepo had all this magic happening.