Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: style pkg exports emotion's css module #718

Merged

Conversation

rusackas
Copy link
Member

💔 Breaking Changes

🏆 Enhancements
Seemed like in general, we should be using css from this superset package, rather than from emotion directly. That means we have a better pivot point, if we ever have the need to migrate to styled-components or some other thing down the road.

📜 Documentation

🐛 Bug Fix

🏠 Internal

@rusackas rusackas requested a review from a team as a code owner July 30, 2020 22:41
@vercel
Copy link

vercel bot commented Jul 30, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/iex650a65
✅ Preview: https://superset-ui-git-fork-preset-io-style-exports-css-from-emotion.superset.vercel.app

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #718 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #718   +/-   ##
=======================================
  Coverage   24.19%   24.19%           
=======================================
  Files         339      339           
  Lines        7617     7617           
  Branches      925      925           
=======================================
  Hits         1843     1843           
  Misses       5701     5701           
  Partials       73       73           
Impacted Files Coverage Δ
packages/superset-ui-style/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dda14c...1ed792d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants