This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: Add ECharts Timeseries plugin #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b37f010.
villebro
changed the title
villebro
commented
Aug 31, 2020
packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Stories.tsx
Outdated
Show resolved
Hide resolved
villebro
commented
Aug 31, 2020
packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Stories.tsx
Show resolved
Hide resolved
|
@ktmud @rusackas I've now introduced a storybook and did those fixes Jesse proposed (thanks so much for patiently helping me with this!). I look forward to improving this going forward, so if we can live with this as the version I'd be stoked if we can press merge and introduce this in |
rusackas
reviewed
Aug 31, 2020
packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Stories.tsx
Outdated
Show resolved
Hide resolved
rusackas
approved these changes
Aug 31, 2020
kristw
reviewed
Aug 31, 2020
ktmud
reviewed
Aug 31, 2020
villebro
force-pushed
the
echarts-poc
branch
from
81617c8 to
cda3bf7
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Add two new ECharts viz plugins: Timeseries and Pie (WIP).
SCREENSHOTS
Regular line chart
Area Chart
Same chart with 52 week predictions (requires installation of
fbpropheton backend)Same predictive chart as stacked area chart
Storybook entry: