Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: remove iframe and markup viz type support #746

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Aug 20, 2020

💔 Breaking Changes

Superset do not support iframe, markup and separator visualization types any more. This PR is to remove plugins from superset-ui.
We already converted iframe into markdown component inside dashboard. see apache/superset#10590

cc @ktmud @kristw

@graceguo-supercat graceguo-supercat requested a review from a team as a code owner August 20, 2020 01:48
@vercel
Copy link

vercel bot commented Aug 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/8mrfpmfb6
✅ Preview: https://superset-ui-git-fork-graceguo-supercat-gg-removeiframesupport.superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #746 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   24.43%   24.47%   +0.04%     
==========================================
  Files         340      333       -7     
  Lines        7645     7632      -13     
  Branches      935      934       -1     
==========================================
  Hits         1868     1868              
+ Misses       5704     5691      -13     
  Partials       73       73              
Impacted Files Coverage Δ
.../legacy-plugin-chart-pivot-table/src/PivotTable.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0e4d1...95827aa. Read the comment docs.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants