-
Notifications
You must be signed in to change notification settings - Fork 272
feat(color): add official ECharts color schemes #751
feat(color): add official ECharts color schemes #751
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/l84hz35b4 |
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 24.43% 24.45% +0.01%
==========================================
Files 334 335 +1
Lines 7652 7654 +2
Branches 937 937
==========================================
+ Hits 1870 1872 +2
Misses 5708 5708
Partials 74 74
Continue to review full report at Codecov.
|
a30618c
to
38b93d5
Compare
I am confused. Why are they called "ECharts 4 colors" and "ECharts 5 colors" when there are more than 4 and 5 colors? |
@kristw it's for version 4.x vs version 5.x. I'll update to make it more clear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🏆 Enhancements
Add ECharts 4.x and 5.x official color schemes.
4.x: https://github.com/apache/incubator-echarts/blob/eb396f27137af1d74b42b1b28752f204a34dbecf/src/model/globalDefault.js#L36-L41
5.x: https://github.com/apache/incubator-echarts/blob/4c916f527f211a34c8dd5555c23870db25a78b05/src/model/globalDefault.ts#L42-L55
Categorical:
Sequential:
Ping @Ovilia