Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: silencing console errors by making MetricOption props optional #752

Merged

Conversation

rusackas
Copy link
Member

💔 Breaking Changes

🏆 Enhancements

📜 Documentation

🐛 Bug Fix
Explore had a bunch of console warnings going on since various implementations of did not provide all the props that the TS definition had listed as mandatory. This loosens up the typing so the console is less painful to look at :)

🏠 Internal

@rusackas rusackas requested a review from a team as a code owner August 25, 2020 23:20
@vercel
Copy link

vercel bot commented Aug 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/q5eqi9ztv
✅ Preview: https://superset-ui-git-fork-preset-io-looser-typing-on-metricoption.superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   24.43%   24.43%           
=======================================
  Files         334      334           
  Lines        7652     7652           
  Branches      937      937           
=======================================
  Hits         1870     1870           
  Misses       5708     5708           
  Partials       74       74           
Impacted Files Coverage Δ
...-ui-chart-controls/src/components/MetricOption.tsx 53.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f090ff...a22c9d4. Read the comment docs.

@rusackas rusackas requested review from ktmud, villebro and a team August 26, 2020 03:59
@rusackas rusackas merged commit 195b7b3 into apache-superset:master Aug 26, 2020
@rusackas rusackas deleted the looser-typing-on-MetricOption branch August 26, 2020 04:30
@mistercrunch
Copy link
Contributor

cleanup

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants