Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: clean up a couple of TypeScript warnings #754

Merged
merged 1 commit into from
Aug 26, 2020
Merged

chore: clean up a couple of TypeScript warnings #754

merged 1 commit into from
Aug 26, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Aug 26, 2020

🏠 Internal

Clean up a couple of TypeScript warnings and @ts-ignore directives.

cc @pkdotson @etr2460 @kristw

@ktmud ktmud requested a review from a team as a code owner August 26, 2020 04:07
@vercel
Copy link

vercel bot commented Aug 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/7s82h4so4
✅ Preview: https://superset-ui-git-fork-ktmud-type-cleanup.superset.vercel.app

@vercel vercel bot temporarily deployed to Preview August 26, 2020 04:07 Inactive
@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited
Loading

Codecov Report

Merging #754 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   24.43%   24.43%           
=======================================
  Files         334      334           
  Lines        7652     7652           
  Branches      937      938    +1     
=======================================
  Hits         1870     1870           
  Misses       5708     5708           
  Partials       74       74
Impacted Files Coverage Δ
...-ui-chart-controls/src/components/MetricOption.tsx 53.33% <ø> (ø)
packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 40.44% <ø> (ø)
...superset-ui-chart-controls/src/utils/mainMetric.ts 100.00% <ø> (ø)
packages/superset-ui-translation/src/Translator.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-time-table/src/TimeTable.tsx 0.00% <0.00%> (ø)
...gacy-plugin-chart-time-table/src/transformProps.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 195b7b3...92edbda. Read the comment docs.

rusackas
rusackas reviewed Aug 26, 2020
View reviewed changes
packages/superset-ui-chart-controls/src/components/MetricOption.tsx
openInNewWindow: boolean;
showFormula: boolean;
showType: boolean;
metric: Metric;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merged in that other pr in case it affects this one.

rusackas
rusackas reviewed Aug 26, 2020
View reviewed changes
plugins/legacy-plugin-chart-time-table/src/TimeTable.tsx
@@ -51,11 +51,12 @@ function colorFromBounds(

// @ts-ignore
return colorScale(value);
// eslint-disable-next-line no-else-return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I kind of prefer reading "else" statements... seems more logical to me. ¯\_(ツ)_/¯

Appreciate all this cleanup work nonetheless! ✨

@ktmud ktmud merged commit 982c09e into apache-superset:master Aug 26, 2020
@ktmud ktmud deleted the type-cleanup branch August 26, 2020 05:43
This was referenced Dec 15, 2021
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktmud @rusackas