Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): disable pie chart animation #816

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

villebro
Copy link
Contributor

🏆 Enhancements
Disable animation in Pie Chart.

Before

piebefore

After

pieafter

@villebro villebro requested a review from a team as a code owner October 28, 2020 07:53
@vercel
Copy link

vercel bot commented Oct 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/8lmgnsfg1
✅ Preview: https://superset-ui-git-villebro-pie-animation.superset.now.sh

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #816 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #816      +/-   ##
==========================================
+ Coverage   25.57%   25.63%   +0.05%     
==========================================
  Files         359      360       +1     
  Lines        7949     7955       +6     
  Branches     1055     1057       +2     
==========================================
+ Hits         2033     2039       +6     
  Misses       5796     5796              
  Partials      120      120              
Impacted Files Coverage Δ
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 73.80% <ø> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <0.00%> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <0.00%> (ø)
...uperset-ui-core/src/query/types/AnnotationLayer.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4eb01f...7a9dcf1. Read the comment docs.

Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants