Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: subject Remove margin to fit last label #900

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented Jan 15, 2021

Remove chart margin-left to fit last label

BEFORE
image
AFTER
image

@ktmud @villebro @rusackas

Fix: apache/superset#12513

@maloun96 maloun96 requested a review from a team as a code owner January 15, 2021 11:47
@vercel
Copy link

vercel bot commented Jan 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4o97u2frb
✅ Preview: https://superset-ui-git-fork-maloun96-hotfix-chart-margin.superset.now.sh

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #900 (037287d) into master (cc11fdb) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
- Coverage   26.73%   26.66%   -0.07%     
==========================================
  Files         405      405              
  Lines        8248     8258      +10     
  Branches     1126     1127       +1     
==========================================
- Hits         2205     2202       -3     
- Misses       5914     5927      +13     
  Partials      129      129              
Impacted Files Coverage Δ
plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js 0.00% <0.00%> (ø)
plugins/plugin-chart-table/src/TableChart.tsx 56.62% <0.00%> (-0.52%) ⬇️
...ugins/plugin-chart-echarts/src/utils/annotation.ts 83.33% <0.00%> (-0.39%) ⬇️
plugins/plugin-chart-table/src/buildQuery.ts 0.00% <0.00%> (ø)
packages/superset-ui-core/src/models/Registry.ts 100.00% <0.00%> (ø)
plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <0.00%> (ø)
plugins/plugin-filter-antd/src/Range/buildQuery.ts 0.00% <0.00%> (ø)
...lugins/plugin-filter-antd/src/Select/buildQuery.ts 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-chord/src/ReactChord.jsx 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc11fdb...037287d. Read the comment docs.

@ktmud ktmud merged commit f20bde1 into apache-superset:master Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chart]all time series charts x-axis got cutoff
2 participants