This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(plugin-chart-table): always sort descending by first metric #935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Follow up for #930 . When there is not "Sort by" metric specified, the original logic pre the API migration is to always sort by the first metric in descending order, regardless if "Sort descending" is set.
Did some refactoring on table chart's
buildQuery
:ensureIsArray
utils, as replacement forextractTimeseriesLimitMetric
queryMode
inference logic to be the same as in the control panel configs.I'm also slipping a small refactor on
buildQueryObject
wherenull
values are fell back toundefined
so thatnull
s are not sent to the backend. Even thought the backend has now taken care ofnull
s as well: apache/superset#12905