Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct zk mutability in docs for TSERV_SESSION_MAXIDLE and TSERV_UPDATE_SESSION_MAXIDLE #4780

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

DomGarguilo
Copy link
Member

Partially addresses #4723

These two props were being incorrectly tagged as being zk mutable. This change makes it so these properties will be properly displayed with "yes but requires restart" in the docs.

@DomGarguilo DomGarguilo added the bug This issue has been verified to be a bug. label Jul 31, 2024
@DomGarguilo DomGarguilo added this to the 2.1.4 milestone Jul 31, 2024
@DomGarguilo DomGarguilo self-assigned this Jul 31, 2024
@ddanielr
Copy link
Contributor

ddanielr commented Aug 2, 2024

This doc update should be applied to the website as part of the 2.1.3 release.

@DomGarguilo DomGarguilo merged commit 61efda6 into apache:2.1 Aug 5, 2024
8 checks passed
@DomGarguilo DomGarguilo deleted the fixSessionManagerDocs branch August 5, 2024 16:19
asfgit pushed a commit to apache/accumulo-website that referenced this pull request Aug 15, 2024
Update the generated server-properties.md to indicate that some
additional properties require restart to take effect. The generated
documentation for these were fixed after 2.1.3 was released, so this
change is to update the docs from the 2.1.4-SNAPSHOT build after
apache/accumulo#4780 was merged.

This fixes #438
dlmarion added a commit to dlmarion/accumulo that referenced this pull request Jan 8, 2025
Reverted changes in apache#4780, which marked the properties as not mutable.
Passed the ServerContext to the sweep method instead of the property
values. The property values are resolved at sweep method execution
time.

Closes apache#4723
dlmarion added a commit that referenced this pull request Jan 9, 2025
…5239)

Reverted changes in #4780, which marked the properties as not mutable.
Passed the ServerContext to the sweep method instead of the property
values. The property values are resolved at sweep method execution
time.

Closes #4723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been verified to be a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants