Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARTEMIS-3168] Implement Kubernetes JaaS LoginModule #4289

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

ruromero
Copy link
Contributor

Implement a Kubernetes LoginModule for ServiceAccounts using the TokenReview API
It is based on the PropertiesLoginModule and does not have any additional runtime dependency.

This is my first contribution to this repository so please, let me know if anything is out of place or does not comply with your best practices.

Signed-off-by: ruromero rromerom@redhat.com

@gtully
Copy link
Contributor

gtully commented Nov 15, 2022

I think this chappy should live in the server module, along with the PropertiesLoginModule that it extends. No need for a separate package.

@ruromero ruromero force-pushed the k8slogin branch 3 times, most recently from c09294f to faa8077 Compare November 15, 2022 11:45
@jbertram
Copy link
Contributor

@ruromero, nice work! Can you squash everything down to a single commit?

@ruromero
Copy link
Contributor Author

@jbertram done

@jbertram
Copy link
Contributor

You've got some test failures:

[INFO] Running org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModuleTest
[main] 15:42:19,023 ERROR [org.apache.activemq.artemis.core.server] AMQ224085: Failed to load property PropsFile=/home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/k8s-roles.properties, reason: /home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/k8s-roles.properties (No such file or directory)
java.io.FileNotFoundException: /home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/home/runner/work/activemq-artemis/activemq-artemis/artemis-server/target/test-classes/k8s-roles.properties (No such file or directory)
	at java.io.FileInputStream.open0(Native Method) ~[?:?]
	at java.io.FileInputStream.open(FileInputStream.java:219) ~[?:?]
	at java.io.FileInputStream.<init>(FileInputStream.java:157) ~[?:?]
	at org.apache.activemq.artemis.spi.core.security.jaas.ReloadableProperties.load(ReloadableProperties.java:164) ~[classes/:?]
	at org.apache.activemq.artemis.spi.core.security.jaas.ReloadableProperties.obtained(ReloadableProperties.java:86) ~[classes/:?]
	at org.apache.activemq.artemis.spi.core.security.jaas.PropertiesLoader.load(PropertiesLoader.java:54) ~[classes/:?]
	at org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModule.initialize(KubernetesLoginModule.java:71) ~[classes/:?]
	at org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModuleTest.testUnableToVerifyToken(KubernetesLoginModuleTest.java:131) ~[test-classes/:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ~[surefire-booter-2.22.2.jar:2.22.2]
Error:  Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.134 s <<< FAILURE! - in org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModuleTest
Error:  testBasicLogin(org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModuleTest)  Time elapsed: 0.009 s  <<< FAILURE!
java.lang.AssertionError: 

Expected: a collection with size <2>
     but: collection size was <0>
	at org.apache.activemq.artemis.spi.core.security.jaas.KubernetesLoginModuleTest.testBasicLogin(KubernetesLoginModuleTest.java:85)
[INFO] Running org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest
[MockServer-EventLog0] 15:42:26,028 ERROR [org.mockserver.log.MockServerEventLog] exception creating SSL context for server'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
java.lang.NoSuchMethodError: 'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
	at org.bouncycastle.cert.X509ExtensionUtils.calculateIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.bouncycastle.cert.X509ExtensionUtils.createSubjectKeyIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.createSubjectKeyIdentifier(BCKeyAndCertificateFactory.java:344) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.generateCACert(BCKeyAndCertificateFactory.java:181) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSaveCertificateAuthorityPrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:77) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSavePrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:208) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.createServerSslContext(NettySslContextFactory.java:191) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.<init>(NettySslContextFactory.java:86) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.createServerBootstrap(MockServer.java:159) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.<init>(MockServer.java:78) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.<init>(MockServer.java:57) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.<init>(ClientAndServer.java:58) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.startClientAndServer(ClientAndServer.java:38) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.startClientAndServer(ClientAndServer.java:34) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest.startServer(KubernetesClientImplTest.java:63) ~[test-classes/:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ~[surefire-booter-2.22.2.jar:2.22.2]
[MockServer-EventLog0] 15:42:26,158 ERROR [org.mockserver.log.MockServerEventLog] exception creating SSL context for server'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
java.lang.NoSuchMethodError: 'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
	at org.bouncycastle.cert.X509ExtensionUtils.calculateIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.bouncycastle.cert.X509ExtensionUtils.createSubjectKeyIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.createSubjectKeyIdentifier(BCKeyAndCertificateFactory.java:344) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.generateCACert(BCKeyAndCertificateFactory.java:181) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSaveCertificateAuthorityPrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:77) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSavePrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:208) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.createServerSslContext(NettySslContextFactory.java:191) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.<init>(NettySslContextFactory.java:86) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.createServerBootstrap(MockServer.java:160) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.<init>(MockServer.java:78) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.netty.MockServer.<init>(MockServer.java:57) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.<init>(ClientAndServer.java:58) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.startClientAndServer(ClientAndServer.java:38) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.mockserver.integration.ClientAndServer.startClientAndServer(ClientAndServer.java:34) ~[mockserver-netty-5.14.0.jar:5.14.0]
	at org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest.startServer(KubernetesClientImplTest.java:63) ~[test-classes/:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) ~[junit-4.13.2.jar:4.13.2]
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413) ~[junit-4.13.2.jar:4.13.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) ~[surefire-junit4-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) ~[surefire-booter-2.22.2.jar:2.22.2]
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) ~[surefire-booter-2.22.2.jar:2.22.2]
[MockServer-EventLog0] 15:42:26,182 INFO  [org.mockserver.log.MockServerEventLog] 35483 started on port: 35483
[MockServer-EventLog0] 15:42:26,182 INFO  [org.mockserver.log.MockServerEventLog] 35483 stopped for port: 35483
[MockServer-ClientStop13] 15:42:26,507 ERROR [org.mockserver.client.MockServerClient] exception creating SSL context for server'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
java.lang.NoSuchMethodError: 'org.bouncycastle.asn1.ASN1BitString org.bouncycastle.asn1.x509.SubjectPublicKeyInfo.getPublicKeyData()'
	at org.bouncycastle.cert.X509ExtensionUtils.calculateIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.bouncycastle.cert.X509ExtensionUtils.createSubjectKeyIdentifier(Unknown Source) ~[bcpkix-jdk18on-1.71.jar:1.71.00.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.createSubjectKeyIdentifier(BCKeyAndCertificateFactory.java:344) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.generateCACert(BCKeyAndCertificateFactory.java:181) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSaveCertificateAuthorityPrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:77) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.bouncycastle.BCKeyAndCertificateFactory.buildAndSavePrivateKeyAndX509Certificate(BCKeyAndCertificateFactory.java:208) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.createServerSslContext(NettySslContextFactory.java:191) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.socket.tls.NettySslContextFactory.<init>(NettySslContextFactory.java:86) ~[mockserver-core-5.14.0.jar:5.14.0]
	at org.mockserver.client.MockServerClient.getNettyHttpClient(MockServerClient.java:342) ~[mockserver-client-java-5.14.0.jar:5.14.0]
	at org.mockserver.client.MockServerClient.sendRequest(MockServerClient.java:393) ~[mockserver-client-java-5.14.0.jar:5.14.0]
	at org.mockserver.client.MockServerClient.sendRequest(MockServerClient.java:429) ~[mockserver-client-java-5.14.0.jar:5.14.0]
	at org.mockserver.client.MockServerClient.lambda$stop$2(MockServerClient.java:666) ~[mockserver-client-java-5.14.0.jar:5.14.0]
	at java.lang.Thread.run(Thread.java:829) ~[?:?]
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.528 s <<< FAILURE! - in org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest
Error:  org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest  Time elapsed: 1.528 s  <<< ERROR!
java.lang.NullPointerException
	at org.apache.activemq.artemis.spi.core.security.jaas.kubernetes.client.KubernetesClientImplTest.startServer(KubernetesClientImplTest.java:73)

@ruromero
Copy link
Contributor Author

@jbertram it's a problem with mockserver dependency. I'm working on it. I didn't spot it in the long build after merging my project into here.

@ruromero ruromero force-pushed the k8slogin branch 6 times, most recently from 70c02da to 64b4c11 Compare November 16, 2022 16:02
@ruromero
Copy link
Contributor Author

@gtully rebased, should be fine
thanks for your patience

@ruromero
Copy link
Contributor Author

@gtully @jbertram is there anything pending? thanks

artemis-server/pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@gtully
Copy link
Contributor

gtully commented Nov 21, 2022

But those errors need some looking into: Error: KubernetesClientImplTest.testGetTokenReview:120 » IllegalState SSLContext is n...

@ruromero
Copy link
Contributor Author

@gtully it was caused by a discrepancy between mockserver deps and the project's

Signed-off-by: ruromero <rromerom@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants