-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARTEMIS-3168] Implement Kubernetes JaaS LoginModule #4289
Conversation
I think this chappy should live in the server module, along with the PropertiesLoginModule that it extends. No need for a separate package. |
c09294f
to
faa8077
Compare
.../src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/KubernetesLoginModule.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/KubernetesLoginModule.java
Outdated
Show resolved
Hide resolved
@ruromero, nice work! Can you squash everything down to a single commit? |
@jbertram done |
You've got some test failures:
|
@jbertram it's a problem with mockserver dependency. I'm working on it. I didn't spot it in the long build after merging my project into here. |
70c02da
to
64b4c11
Compare
@gtully rebased, should be fine |
But those errors need some looking into: Error: KubernetesClientImplTest.testGetTokenReview:120 » IllegalState SSLContext is n... |
@gtully it was caused by a discrepancy between mockserver deps and the project's |
Signed-off-by: ruromero <rromerom@redhat.com>
Implement a Kubernetes LoginModule for ServiceAccounts using the TokenReview API
It is based on the PropertiesLoginModule and does not have any additional runtime dependency.
This is my first contribution to this repository so please, let me know if anything is out of place or does not comply with your best practices.
Signed-off-by: ruromero rromerom@redhat.com