Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMQ-9296] Add support of credentials to the docker image #1050

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Sep 8, 2023

Fixes https://issues.apache.org/jira/browse/AMQ-9296

Motivation

Since Docker images for Apache ActiveMQ are published, it would be great to support env vars for USER and PASSWORD.

Modifications:

  • Add an entry point script to generate the configuration files if the environment variable ACTIVEMQ_USER is set
  • Describe the supported environment variables

@jbonofre jbonofre self-requested a review September 8, 2023 08:00
Copy link
Member

@jbonofre jbonofre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure adding an authenication plugin is what's expected.
IMHO, the user (in Jira) is asking for authentication on the webconsole, so updating jetty-realm.properties. The same can apply to credentials.properties and users.properties. I can explain to you the use of those different files.
So I think, we could have different env variables, depending the credentials we want to set.

@essobedo
Copy link
Contributor Author

I understand the differences with the authentication on the web console, I simply believed that it is what the OP was expecting. I guess the OP needs to clarify a bit more because it is really unclear/misleading

@jbonofre
Copy link
Member

Agree, the ticket should provide some details. However, I think it would be acceptable to have different env variables, depending what kind of credentials we want to provide.

@jbonofre
Copy link
Member

jbonofre commented Nov 10, 2023

Superseded by #1114

@jbonofre jbonofre closed this Nov 10, 2023
@essobedo essobedo deleted the AMQ-9296/add-support-of-credentials-to-docker-image branch November 10, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants