Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG15] Added toBooleanList() #1014

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

MatheusFarias03
Copy link
Contributor

- Essentially the same as openCypher's toBooleanList() function: https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tobooleanlist
- The toBooleanList() function converts a list of values and returns a list of boolean values.
- If any values are not convertible to boolean they will be null in the list returned.
- Also created the regression tests for it.
@dehowef dehowef self-requested a review August 18, 2023 03:17
@dehowef
Copy link
Member

dehowef commented Aug 18, 2023

Looks good to me.

@dehowef
Copy link
Member

dehowef commented Aug 18, 2023

@MatheusFarias03 can you make this pull request for each of the previous PG versions? For PG 11,12,13, and 14? Thanks

@MatheusFarias03 MatheusFarias03 changed the title Implemented the toBooleanList() function [PG15] Added toBooleanList() Aug 18, 2023
@MatheusFarias03
Copy link
Contributor Author

MatheusFarias03 commented Aug 18, 2023

@dehowef , I've created other PRs for each Postgres version. If there is something wrong with any of them, please let me know. Thank you for considering my contribution.

@dehowef dehowef merged commit eb29e00 into apache:master Aug 18, 2023
6 checks passed
@MatheusFarias03 MatheusFarias03 deleted the toBooleanList branch August 18, 2023 22:53
jrgemignani pushed a commit that referenced this pull request Dec 13, 2023
- Essentially the same as openCypher's toBooleanList() function: https://neo4j.com/docs/cypher-manual/current/functions/list/#functions-tobooleanlist
- The toBooleanList() function converts a list of values and returns a list of boolean values.
- If any values are not convertible to boolean they will be null in the list returned.
- Also created the regression tests for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants