Fix issue 1033: access operator on vle edge lists #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
Please hold off on merging this PR. After reviewing Taha's PR #1034, I feel that this one could incorporate some of his logic and could use some clarifying comments. Thank you @MuhammadTahaNaveed for your work too! |
|
@MuhammadTahaNaveed I will look at how this relates to #395. |
jrgemignani
force-pushed
the
fix_issue_1033
branch
from
f757344
to
4334515
Compare
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
|
@MuhammadTahaNaveed #395 appears to have to do with a different issue, somewhere in the collect function. |
|
If everyone is happy with this PR - which has been modified - please merge it :) |
Oh okay..... 👍 |
@MuhammadTahaNaveed Could you merge this PR? :) |
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jul 17, 2023
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
jrgemignani
added a commit
to jrgemignani/age
that referenced
this pull request
Jul 17, 2023
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
M4rcxs
pushed a commit
to M4rcxs/age
that referenced
this pull request
Jul 18, 2023
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
dehowef
pushed a commit
that referenced
this pull request
Jul 18, 2023
dehowef
pushed a commit
that referenced
this pull request
Jul 18, 2023
muhammadshoaib
pushed a commit
to muhammadshoaib/age
that referenced
this pull request
Jul 20, 2023
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
MuhammadTahaNaveed
pushed a commit
to MuhammadTahaNaveed/age
that referenced
this pull request
Aug 24, 2023
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator. Added regression tests. A big thanks to Taha for showing that this function could be simplified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where the edge lists generated by the vle function couldn't be resolved by the agtype_access_operator.
Added regression tests.