Commits on Oct 24, 2023

1. Fix Issue 945 - incorrect count(*) return values …

   Fixed issue 945 where count(*) would have incorrect return values.
   
   NOTE -
   
   We need to re-evaluate if we want to use output_node or not.
   If output_node is set to false, then it basically short circuits
   match for instances where a variable isn't specified -
   
       MATCH () RETURN 0;
       MATCH () MATCH () RETURN 0;
   
   While, on the surface, this appears to be a good way to improve
   execution time of commands that won't do anything, it also
   causes chained commands to not work correctly. This is because
   a match without a variable will still feed its tuples to the next
   stage(s) even though they won't necessarily be sent to the output.
   For example, with count(*) -
   
       MATCH () RETURN count(*);
       MATCH () MATCH RETURN count(*);
   
   With output_node set to false, it won't send the tuples. We will
   likely need to remove all of the output_node logic. However, this
   needs to be reviewed. For now, we just set it to true and update
   the output of the regression tests.
   
   Updated regression tests to accomodate the change.
   Added new regression tests to cover overlooked cases.

   

   jrgemignani committed Oct 24, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8c4f18d
   • Browse repository at this point

   Copy the full SHA

   8c4f18d View commit details

   Browse the repository at this point in the history