Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile as a development environment #943

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

panosfol
Copy link
Contributor

@panosfol panosfol commented May 21, 2023

  • Dockerfile.dev:
    This variation of the original Dockerfile is introduced to
    help developers run their testsuite in the build phase of the
    docker image.

  • .dockerignore:
    Added .dockerignore to avoid conflicts with ".so" files

Closes #936

@panosfol panosfol force-pushed the docker branch 2 times, most recently from af1cee6 to 84b30af Compare May 22, 2023 15:38
@jrgemignani
Copy link
Contributor

@panosfol Will creating an moving the Dockerfile to another directory be okay?

@dehowef dehowef self-requested a review June 23, 2023 21:38
@panosfol
Copy link
Contributor Author

panosfol commented Jun 24, 2023

@jrgemignani IMO it's irrelevant whether we move the Dockerfiles in another directory or keep it at root. This is done just to avoid bloating of the root folder by adding Dockerfile.dev.

Running via docker build should be the same if you specify -f <Dockerfile> or --file <Dockerfile>

@jrgemignani
Copy link
Contributor

jrgemignani commented Jun 29, 2023

@eyab and myself will need to verify that Dockerhub won't be impacted by these changes. That would be my only concern atm, and possibly, other items pointing to, or using, the docker file. Unless, I'm misunderstanding the docker file usage.

@panosfol
Copy link
Contributor Author

@eyab and myself will need to verify that Dockerhub won't be impacted by these changes. That would be my only concern atm, and possibly, other items pointing to, or using, the docker file. Unless, I'm misunderstanding the docker file usage.

The Dockerfile that is being used by Dockerhub remains unchanged therefore no problem will arise. The new dockerfile that was added is strictly for development puproses.

@jrgemignani
Copy link
Contributor

@panosfol One of us (likely @eyab or myself) will try to look into this this week. The hold up has been other work and the move from PostgreSQL 11 to 12. We will need to review the Dockerhub setup, which is why I've been holding this PR off.

docker/Dockerfile.dev Outdated Show resolved Hide resolved
docker/Dockerfile.dev Outdated Show resolved Hide resolved
@jrgemignani
Copy link
Contributor

@panosfol Once this PR has been approved and merged, you will need to create one tailored to PostgreSQL 11 and submit it against the PG11 branch.

@panosfol
Copy link
Contributor Author

@jrgemignani Fixed!

@panosfol
Copy link
Contributor Author

@jrgemignani should this be changed for PG13? And produce 2 more for PG12 and PG11?

Dockerfile.dev:
  This variation of the original Dockerfile is introduced to
  help developers run their testsuite in the build phase of the
  docker image.
.dockerignore:
  Added .dockerignore to avoid conflicts with ".so" files

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
@jrgemignani
Copy link
Contributor

@jrgemignani should this be changed for PG13? And produce 2 more for PG12 and PG11?

I'm going to have one other review this and then, provided everything is okay, merge it into the master. Assuming all goes well and there are no issues, you can create those additional PRs.

Copy link
Member

@MuhammadTahaNaveed MuhammadTahaNaveed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@jrgemignani jrgemignani merged commit 10fe47c into apache:master Jul 19, 2023
6 checks passed
panosfol added a commit to panosfol/age that referenced this pull request Jul 20, 2023
…pache#943)

Dockerfile.dev:
  This variation of the original Dockerfile is introduced to
  help developers run their testsuite in the build phase of the
  docker image.
.dockerignore:
  Added .dockerignore to avoid conflicts with ".so" files

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
muhammadshoaib pushed a commit to muhammadshoaib/age that referenced this pull request Jul 20, 2023
…pache#943)

Dockerfile.dev:
  This variation of the original Dockerfile is introduced to
  help developers run their testsuite in the build phase of the
  docker image.
.dockerignore:
  Added .dockerignore to avoid conflicts with ".so" files

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
MuhammadTahaNaveed pushed a commit to MuhammadTahaNaveed/age that referenced this pull request Aug 24, 2023
…pache#943)

Dockerfile.dev:
  This variation of the original Dockerfile is introduced to
  help developers run their testsuite in the build phase of the
  docker image.
.dockerignore:
  Added .dockerignore to avoid conflicts with ".so" files

Signed-off-by: Panagiotis Foliadis <pfoliadis@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile as a development environment
3 participants