Fix issue #975 Invalid reuse of variables in CREATE clause

[MuhammadTahaNaveed]

• Added checks for invalid use of variables in create clause.
• Fixed error position of path and node variables.
• Added regression tests.

resolves #975

[dehowef]

Looks good to me.

[rafsun42]

@MuhammadTahaNaveed Would the following query work:

MATCH (p:Person) WITH p AS r CREATE p=(a:Person)-[:Manages]->(r) return r

I get the following error. It has probably nothing to do with your changes.

test=# SELECT * FROM cypher('hey', $$ MATCH (p:Person) WITH p AS r CREATE p=(a:Person)-[:Manages]->(r) return r $$) as (a agtype);
ERROR:  ag function does not exist
LINE 1: SELECT * FROM cypher('hey', $$ MATCH (p:Person) WITH p AS r ...
                                     ^
DETAIL:  agtype_volatile_wrapper(1)

[MuhammadTahaNaveed]

@MuhammadTahaNaveed Would the following query work:

MATCH (p:Person) WITH p AS r CREATE p=(a:Person)-[:Manages]->(r) return r

I get the following error. It has probably nothing to do with your changes.

test=# SELECT * FROM cypher('hey', $$ MATCH (p:Person) WITH p AS r CREATE p=(a:Person)-[:Manages]->(r) return r $$) as (a agtype);
ERROR:  ag function does not exist
LINE 1: SELECT * FROM cypher('hey', $$ MATCH (p:Person) WITH p AS r ...
                                     ^
DETAIL:  agtype_volatile_wrapper(1)

@rafsun42 Hi, yes this query should work. And it is working fine at my end.

[rafsun42]

Okay, looks good.