Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspellings in many AGE files #985

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jun 13, 2023

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/age/actions/runs/5251077113#summary-14208871486

Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most corrections automatically suggested by Google Sheets. All fault mine

CONTRIBUTING.md Show resolved Hide resolved
README.md Show resolved Hide resolved
drivers/golang/install.sh Show resolved Hide resolved
src/backend/executor/cypher_create.c Show resolved Hide resolved
regress/expected/expr.out Show resolved Hide resolved
regress/expected/index.out Show resolved Hide resolved
src/backend/parser/cypher_expr.c Show resolved Hide resolved
/* vertex entry for the vertex_hastable */
/* vertex entry for the vertex_hashtable */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one need to be checked in source code as well.

@dehowef
Copy link
Member

dehowef commented Jun 15, 2023

The changes that affect spellings in actual code and not just comments might have had an issue, but all regression tests passed, and I reviewed all of the changes manually myself. It looks good, but can you squash all the commits down into one commit?

@jsoref
Copy link
Contributor Author

jsoref commented Jun 16, 2023

@dehowef squashed

@muhammadshoaib
Copy link
Contributor

Looks good to me.

@jrgemignani
Copy link
Contributor

@jsoref Please squash your comments to something more descriptive without listing all of the words fixed.

For example, for the commit description, something like "Fix misspellings in many AGE files (#985)"

For example, for the more detailed descriptions, mention what was done (a general description) and why. But, you don't need to list all of the individual changes. Just a good summary.

@jrgemignani
Copy link
Contributor

@jsoref @dehowef @muhammadshoaib There are code reviews that need to be resolved.

jsoref added a commit to jsoref/age that referenced this pull request Jun 16, 2023
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jrgemignani
Copy link
Contributor

@jsoref -

For example, for the more detailed descriptions, mention what was done (a general description) and why. But, you don't need to list all of the individual changes. Just a good summary.

image

Copy link
Member

@dehowef dehowef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but please change the description of the commit to a brief summary

regress/expected/expr.out Show resolved Hide resolved
@jrgemignani
Copy link
Contributor

@jsoref Please see above comments that are still waiting for you.

@jsoref jsoref changed the title Spelling Fix misspellings in many AGE files Jun 22, 2023
Corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling).

The misspellings were reported at https://github.com/jsoref/age/actions/runs/5251076994#summary-14208871240

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Copy link
Contributor Author

jsoref commented Jun 26, 2023

@jrgemignani is this good enough?

@jrgemignani jrgemignani merged commit d3a3bd5 into apache:master Jun 27, 2023
@jsoref jsoref deleted the spelling branch June 27, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants