Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task_instance.py #89

Closed
wants to merge 1 commit into from
Closed

Conversation

almost-online
Copy link

Apache Airflow Version: v2.6.3

Fixing a trigger and a triggerer_job properties as nullable

Fixing a `trigger` and a `triggerer_job` properties as nullable
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jul 26, 2023

The client is auto-generated. This is the same issue we had recently, where the 'nullable' property is ignored next to a $ref attribute in the OpenAPI spec. (which is expected)

  1. The long term fix would be to fix the OpenAPI spec. This way any clients going forward would be correct.

  2. The workaround we have for now is described in our client release process:

    Cherry-pick this commit: ddd6fc0

    In a similar way we can merge this PR and then also add instructions on also cherry picking this particular commit in our release process.

2) Will quickly become unmanageable and will not fix the issues for all instances we have of misusing the nullable prop next to a ref in our spec. This is just a band aid.

I think the correct move would be 1) and then wait for 2.6.3 client version. (To be release soon as part of our next airflow core patch release)

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jul 27, 2023

PR for 1) is here:
apache/airflow#32887

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Aug 2, 2023

Closing, should be resolved in next release. (if it make it to 2.7.0, otherwise 2.7.1 will have the fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants