Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task modal links are broken in the dag gantt view #19252

Closed
2 tasks done
robinedwards opened this issue Oct 27, 2021 · 0 comments · Fixed by #19258
Closed
2 tasks done

Task modal links are broken in the dag gantt view #19252

robinedwards opened this issue Oct 27, 2021 · 0 comments · Fixed by #19258
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:bug This is a clearly a bug
Milestone

Comments

@robinedwards
Copy link
Contributor

robinedwards commented Oct 27, 2021

Apache Airflow version

2.2.0 (latest released)

Operating System

Debian GNU/Linux 11 (bullseye)

Versions of Apache Airflow Providers

N/A

Deployment

Other Docker-based deployment

Deployment details

CeleryExecutor / ECS / Postgres

What happened

image

Clicking on logs / instance details on the following dialog causes an exception:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.9/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.9/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.9/site-packages/airflow/www/auth.py", line 51, in decorated
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/airflow/www/decorators.py", line 63, in wrapper
    log.execution_date = pendulum.parse(execution_date_value, strict=False)
  File "/usr/local/lib/python3.9/site-packages/pendulum/parser.py", line 29, in parse
    return _parse(text, **options)
  File "/usr/local/lib/python3.9/site-packages/pendulum/parser.py", line 45, in _parse
    parsed = base_parse(text, **options)
  File "/usr/local/lib/python3.9/site-packages/pendulum/parsing/__init__.py", line 74, in parse
    return _normalize(_parse(text, **_options), **_options)
  File "/usr/local/lib/python3.9/site-packages/pendulum/parsing/__init__.py", line 120, in _parse
    return _parse_common(text, **options)
  File "/usr/local/lib/python3.9/site-packages/pendulum/parsing/__init__.py", line 177, in _parse_common
    return date(year, month, day)
ValueError: year 0 is out of range

This is because the execution_date in the query param of the url is empty i.e:

http://localhost:50008/log?dag_id=test_logging&task_id=check_exception_to_sentry&execution_date=

What you expected to happen

The logs to load / task instance detail page to load

How to reproduce

See above

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@robinedwards robinedwards added area:core kind:bug This is a clearly a bug labels Oct 27, 2021
@robinedwards robinedwards changed the title task modal links broken in gantt view Task modal links are broken in the dag gantt view Oct 27, 2021
@kaxil kaxil added this to the Airflow 2.2.2 milestone Oct 27, 2021
@bbovenzi bbovenzi added area:webserver Webserver related Issues area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants