Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow 2.2.1rc2 #19246

Closed
24 of 37 tasks
potiuk opened this issue Oct 27, 2021 · 21 comments
Closed
24 of 37 tasks

Status of testing of Apache Airflow 2.2.1rc2 #19246

potiuk opened this issue Oct 27, 2021 · 21 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@potiuk
Copy link
Member

potiuk commented Oct 27, 2021

Airflow 2.2.1rc2 testing

We have a kind request for all the contributors to the latest Apache Airflow RC 2.2.1rc2.

Could you please help us to test the RC versions of Airflow?

Please let us know in the comment if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@ephraimbuddy @JavierLopezT @jedcunningham @sbialkowski-pixel @Jorricks @khalidmammadov @john-jac @brain-buster @andrewgodwin @joshzana @SamWheating @mik-laj @leonsmith @ReadytoRocc @ashb @robinedwards @potiuk @bbovenzi @jordanjeremy @steveyz-astro @BasPH @hpatel-higi @uranusjr @andreychernih

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@potiuk potiuk added the kind:meta High-level information important to the community label Oct 27, 2021
@raphaelauv
Copy link
Contributor

python3 -m pip install apache-airflow[postgres]==2.2.1rc2 --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc2/constraints-3.9.txt"

log

ERROR: Cannot install apache-airflow because these package versions have conflicting dependencies.

The conflict is caused by:
    flask-appbuilder 3.3.2 depends on Flask-OpenID<2 and >=1.2.5
    The user requested (constraint) flask-openid==1.2.5

@potiuk potiuk changed the title Status of testing of Apache Airflow 2.2.1 rc2 Status of testing of Apache Airflow 2.2.1rc2 Oct 27, 2021
@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

python3 -m pip install apache-airflow[postgres]==2.2.1rc2 --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc2/constraints-3.9.txt"

log

ERROR: Cannot install apache-airflow because these package versions have conflicting dependencies.

The conflict is caused by:
    flask-appbuilder 3.3.2 depends on Flask-OpenID<2 and >=1.2.5
    The user requested (constraint) flask-openid==1.2.5

This error makes no sense >=1.2.5 is ok for 1.2.5.

  1. Are you sjure you used the right Python version?
  2. Can you upgrade PIP to latest version

@uranusjr - I have no time to take a look at it soon, can you please take a look? I think we had similar case before that wrong conflict was reported

@kaxil
Copy link
Member

kaxil commented Oct 27, 2021

Yeah the error is weird !!

@raphaelauv
Copy link
Contributor

raphaelauv commented Oct 27, 2021

using python 3.9 ( pip version is 21.3.1 )

but for 2.2.1rc1 I do not have the problem

python3 -m pip install apache-airflow[postgres]==2.2.1rc1 --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc1/constraints-3.9.txt"

@uranusjr
Copy link
Member

uranusjr commented Oct 27, 2021

The final error message is bad, but an error is emitted that indicates the real issue:

Collecting Flask-OpenID==1.2.5
  Downloading Flask-OpenID-1.2.5.tar.gz (43 kB)
     |████████████████████████████████| 43 kB 699 kB/s
  Preparing metadata (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: /home/uranusjr/Documents/play/airflow-221rc2-flask-openid/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-iqrcgtl5/flask-openid_b6dd0035aaa24038a0cbc5a5b9b113c7/setup.py'"'"'; __file__='"'"'/tmp/pip-install-iqrcgtl5/flask-openid_b6dd0035aaa24038a0cbc5a5b9b113c7/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-ydevayvc
       cwd: /tmp/pip-install-iqrcgtl5/flask-openid_b6dd0035aaa24038a0cbc5a5b9b113c7/
  Complete output (1 lines):
  error in Flask-OpenID setup command: use_2to3 is invalid.
  ----------------------------------------
WARNING: Discarding https://files.pythonhosted.org/packages/d1/a2/9d1fba3287a65f81b9d1c09c4f7cb16f8ea4988b1bc97ffea0d60983338f/Flask-OpenID-1.2.5.tar.gz#sha256=5a8ffe1c8c0ad1cc1f5030e1223ea27f8861ee0215a2a58a528cc61379e5ccab (from https://pypi.org/simple/flask-openid/). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

So this is the same use_2to3 issue we had previously. The constraints file should pin Flask-OpenID to 1.3.0 (which has a pre-built wheel available) instead of 1.2.5.

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

So this is the same use_2to3 issue we had previously. The constraints file should pin Flask-OpenID to 1.3.0 (which has a pre-built wheel available) instead of 1.2.5.

Fixing it!

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

Thanks @uranusjr I knew I saw it before!

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

Resolved - the constraint tag was wrongly set (it was set to be the same as 2.1.0b1. It should work now @raphaelauv !

@raphaelauv
Copy link
Contributor

@potiuk yes now it work , sorry for not pointing to the reel error , thanks @uranusjr

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

Cool! Also Docker Images are rebuilt and pushed now with the updated constraints. All should be good for testing 🚀

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2021

Just tested - the #19010 - works fine - LD_PRELOAD is propely set in the image 👍

@robinedwards
Copy link
Contributor

#18943 is fixed

@robinedwards
Copy link
Contributor

I just discovered #19252 not sure if its a blocker though

@kaxil
Copy link
Member

kaxil commented Oct 27, 2021

Yeah that sounds like a regression unfortunately :( -- was it working in 2.2.0 @robinedwards ?

@robinedwards
Copy link
Contributor

No it doesn't work in 2.2.0 either

@kaxil
Copy link
Member

kaxil commented Oct 27, 2021

Aah ok -- in that case it is not a regression so not a blocker. Let's fix it for 2.2.2

@leonsmith
Copy link
Contributor

#18980 looks good 👍

@jordanjeremy
Copy link
Contributor

confirmed that #18956 is fixed

@jedcunningham
Copy link
Member

Tested #18926, #19034, #19166, #19183, #19179, #19185.

I also partially tested #19088, though I didn't tick this one off. I only verified manual runs logged into their own files which only uses ts.

@potiuk
Copy link
Member Author

potiuk commented Oct 29, 2021

I also ticked off all the "docs/test only" changes (should have been removed from the issue in the first place which we can do in the future).

I guess we have few more hours to test the remaining ones (if possible) :)

@jedcunningham
Copy link
Member

Thanks everyone for testing! Apache Airflow 2.2.1 (based on RC2) has been accepted.

I'll continue with the release process, and the release announcement will follow shortly.

@potiuk potiuk added the testing status Status of testing releases label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

8 participants