Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group PATCH DAGrun together with other DAGRun endpoints #18885

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

BasPH
Copy link
Contributor

@BasPH BasPH commented Oct 11, 2021

The endpoint to modify DAGRuns added in #17839 is given a new tag "UpdateDagRunState", but I think it belongs together with the other DAGRun endpoints, which this PR does.

WRT the 2.2 release: this PR only changes the grouping, the endpoint itself remains the same, so IMO this is fine for the 2.2.1 release.

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Oct 11, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 11, 2021
@kaxil kaxil merged commit d27dffd into apache:main Oct 11, 2021
@kaxil kaxil added this to the Airflow 2.2.1 milestone Oct 11, 2021
jedcunningham pushed a commit that referenced this pull request Oct 14, 2021
Co-authored-by: Bas Harenslak <bas@astronomer.io>

The endpoint to modify DAGRuns added in #17839 is given a new tag "UpdateDagRunState", but I think it belongs together with the other DAGRun endpoints, which this PR does.

WRT the 2.2 release: this PR only changes the grouping, the endpoint itself remains the same, so IMO this is fine for the 2.2.1 release.

![image](https://user-images.githubusercontent.com/6249654/136782577-120f7b4d-7b70-49c8-9a1f-f70d368ad9b2.png)

(cherry picked from commit d27dffd)
@BasPH BasPH deleted the group-dagrun-endpoints branch October 22, 2021 12:32
@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants