Faster db migration to Airflow 2.2 #19166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ashb,
potiuk,
uranusjr,
ephraimbuddy and
kaxil
jedcunningham
force-pushed
the
faster_2.2.0_migrations
branch
from
1daa77a to
4834fb8
Compare
jedcunningham
force-pushed
the
faster_2.2.0_migrations
branch
from
4834fb8 to
9b3f4cc
Compare
ashb
approved these changes
Oct 22, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Oct 23, 2021
|
Well done 👏 Looks like all SQLite tests are failing, I haven't looked at failures but you might have to special case SQLite in some instances |
|
Needs rebase? |
Bigger Airflow databases can take a long time to migrate the database, particularly if they have a lot of task instances. Dropping indexes before setting `run_id` from `dag_run` allows the update to complete faster.
jedcunningham
force-pushed
the
faster_2.2.0_migrations
branch
from
9c316e1 to
65e9d39
Compare
ashb
approved these changes
Oct 24, 2021
Doesn't hurt. Images weren't built quickly enough, but they were for this run thankfully. |
potiuk
approved these changes
Oct 24, 2021
jedcunningham
added a commit
that referenced
this pull request
Oct 24, 2021
Bigger Airflow databases can take a long time to migrate the database, particularly if they have a lot of task instances. On PostgreSQL, creating a new table is much faster than updating the existing table. (cherry picked from commit 559d607)
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
Bigger Airflow databases can take a long time to migrate the database, particularly if they have a lot of task instances. On PostgreSQL, creating a new table is much faster than updating the existing table. (cherry picked from commit 559d607)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
Bigger Airflow databases can take a long time to migrate the database, particularly if they have a lot of task instances. On PostgreSQL, creating a new table is much faster than updating the existing table.
37 tasks
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2021
Bigger Airflow databases can take a long time to migrate the database, particularly if they have a lot of task instances. On PostgreSQL, creating a new table is much faster than updating the existing table. (cherry picked from commit 559d607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigger Airflow databases can take a long time to migrate the database,
particularly if they have a lot of task instances. Dropping indexes
before setting
run_idfromdag_runallows the update to completefaster.
With my test database containing 2.28 million task instances, this resulted in
a significantly faster migration (~145s to ~50s).