-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row lock TI query in SchedulerJob._process_executor_events #18975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa! Good one!
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Using multiple schedulers causes Deadlock in _process_executor_events. This PR fixes it.
985caf4
to
38747ee
Compare
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Looks green! BTW. We have LOT MORE GREEN nowadays after all those small flaky test fixes :D. |
Yay!! 🎉🎉 Thanks for the good works🙌🙌 |
Using multiple schedulers causes Deadlock in _process_executor_events. This PR fixes it. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 52cc84c)
) Using multiple schedulers causes Deadlock in _process_executor_events. This PR fixes it. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 52cc84c)
) Using multiple schedulers causes Deadlock in _process_executor_events. This PR fixes it. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 52cc84c)
) Using multiple schedulers causes Deadlock in _process_executor_events. This PR fixes it. Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 52cc84c)
Using multiple schedulers causes Deadlock in _process_executor_events.
This PR fixes it.
The error:
I tested the fix with 3 schedulers and it works.
How to reproduce:
Using 2 schedulers and celery executor, run this dag:
dags.zip
One scheduler will stop with errors like the above after some time.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.