Fixes #18943 null execution date on insert to task_fail violating NOT NULL #18979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dag_run property isn't populated by refresh_from_db or when this is called from the failure handler when reaping zombies. This resulted in an IntegrityError violating the NOT NULL constraint on task_fail
ephraimbuddy
approved these changes
Oct 14, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
reviewed
Oct 14, 2021
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
uranusjr
approved these changes
Oct 14, 2021
potiuk
approved these changes
Oct 14, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Oct 14, 2021
…NULL (#18979) Fixes #18943 null exec date on insert to task_fail The dag_run property isn't populated by refresh_from_db or when this is called from the failure handler when reaping zombies. This resulted in an IntegrityError violating the NOT NULL constraint on task_fail (cherry picked from commit 2966e3c)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert into task_fail table fails when reaping zombies from the dag processor.
The dag_run property isn't populated by
ti.refresh_from_db()or by the failure handler.This resulted in an IntegrityError violating the NOT NULL constraint on execution_date in the task_fail table on Airflow 2.2.0
See #18943 for details