Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18943 null execution date on insert to task_fail violating NOT NULL #18979

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Fixes #18943 null execution date on insert to task_fail violating NOT NULL #18979

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3637e90
Fixes #18943 null exec date on insert to task_fail
robinedwards Oct 14, 2021
6faa5f9
Pass db session from parent site
uranusjr Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airflow/models/taskinstance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,7 +1702,8 @@ def handle_failure(
session.add(Log(State.FAILED, self))

# Log failure duration
session.add(TaskFail(task, self.execution_date, self.start_date, self.end_date))
dag_run = self.get_dagrun() # self.dag_run not populated by refresh_from_db
uranusjr marked this conversation as resolved.
Show resolved Hide resolved
session.add(TaskFail(task, dag_run.execution_date, self.start_date, self.end_date))

# Ensure we unset next_method and next_kwargs to ensure that any
# retries don't re-use them.
Expand Down