Workaround libstdcpp TLS error #19010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround apache#17546 issue with /usr/lib/x86_64-linux-gnu/libstdc++.so.6: cannot allocate memory in static TLS block. We do not yet a more "correct" solution to the problem but in order to avoid raising new issues by users of the prod image, we implement the workaround now. The side effect of this is slightly (in the range of 100s of milliseconds) slower load for any binary started and a little memory used for Heap allocated by initialization of libstdc++. This overhead is not happening for binaries that already link dynamically libstdc++.
boring-cyborg
bot
added
area:dev-tools
area:production-image
|
Hey @kaxil @jedcunningham - seems that more and more people have the problem with libstdc++ - this one should workaround it until we find a "proper" fix - with limited "overhead" introduced, I think we should cherry-pick it to include it in 2.2.1 |
|
(not sure If I will be around to merge it :D |
uranusjr
reviewed
Oct 18, 2021
uranusjr
approved these changes
Oct 19, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
jedcunningham
pushed a commit
that referenced
this pull request
Oct 20, 2021
Workaround #17546 issue with /usr/lib/x86_64-linux-gnu/libstdc++.so.6: cannot allocate memory in static TLS block. We do not yet a more "correct" solution to the problem but in order to avoid raising new issues by users of the prod image, we implement the workaround now. The side effect of this is slightly (in the range of 100s of milliseconds) slower load for any binary started and a little memory used for Heap allocated by initialization of libstdc++. This overhead is not happening for binaries that already link dynamically libstdc++. (cherry picked from commit 8858309)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
Workaround apache#17546 issue with /usr/lib/x86_64-linux-gnu/libstdc++.so.6: cannot allocate memory in static TLS block. We do not yet a more "correct" solution to the problem but in order to avoid raising new issues by users of the prod image, we implement the workaround now. The side effect of this is slightly (in the range of 100s of milliseconds) slower load for any binary started and a little memory used for Heap allocated by initialization of libstdc++. This overhead is not happening for binaries that already link dynamically libstdc++.
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround #17546 issue with
/usr/lib/x86_64-linux-gnu/libstdc++.so.6: cannot allocate memory in
static TLS block.
We do not yet a more "correct" solution to the problem but in order to
avoid raising new issues by users of the prod image, we implement the
workaround now.
The side effect of this is slightly (in the range of 100s of
milliseconds) slower load for any binary started and a little memory
used for Heap allocated by initialization of libstdc++.
This overhead is not happening for binaries that already link
dynamically libstdc++.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.