Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about unsupported Python 3.10 #19060

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Oct 19, 2021

Related: #19059
Some users are unaware of the supported Python versions and then have trouble using Airflow. It's best to alert them to be aware of potential compatibility issues. For example, see:
https://stackoverflow.com/questions/69615585/unable-to-start-airflow-webserver-with-python-3-10


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj requested review from potiuk and uranusjr October 19, 2021 02:06
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure if it's best to reference a GitHub issue. We should probably create a documentation page explaining the Python version support policy, and change the message to a more generic Python {version} is not officially supported on this version of Airflow.

airflow/__main__.py Outdated Show resolved Hide resolved
@mik-laj
Copy link
Member Author

mik-laj commented Oct 19, 2021

@uranusjr We can describe the assumptions in general, but that won't give a full description of whether Airflow supports Python 3.10 or not, as Python 3.10 may not be supported by dependency issues that can be fixed after a new version is released. I will also add information to the documentation about the issue.

CDAP also informs users of known issues with a link to the ticket. https://cdap.atlassian.net/wiki/spaces/DOCS/pages/1162707265/CDAP+Release+6.4.0#Known-Issues

@mik-laj mik-laj requested a review from kaxil as a code owner October 19, 2021 11:11
@mik-laj mik-laj added this to the Airflow 2.2.1 milestone Oct 19, 2021
@mik-laj mik-laj requested a review from uranusjr October 19, 2021 18:27
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise lgtm.

airflow/__main__.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just 1 trivial nit.

README.md Outdated Show resolved Hide resolved
docs/apache-airflow/installation/prerequisites.rst Outdated Show resolved Hide resolved
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@uranusjr uranusjr merged commit c14aed3 into apache:main Oct 21, 2021
jedcunningham pushed a commit that referenced this pull request Oct 21, 2021
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
(cherry picked from commit c14aed3)
jedcunningham pushed a commit that referenced this pull request Oct 21, 2021
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
(cherry picked from commit c14aed3)
sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants