fail backfill command before loading DAGs if missing args #18994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Oct 15, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
kaxil
approved these changes
Oct 15, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Oct 15, 2021
…18994) I was looking through some of the CLI code last week trying to improve the speed of `airflow user` commands and I noticed this small issue. If neither the `start_date` or `end_date` argument is provided then the command will fail, but it will first parse all of the DAGs which can take up to several minutes in large deployments. Now the command will fail faster, allowing the user to adjust their command and retry. (cherry picked from commit b814ab4)
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through some of the CLI code last week trying to improve the speed of
airflow usercommands and I noticed this small issue.If neither the
start_dateorend_dateargument is provided then the command will fail, but it will first parse all of the DAGs which can take up to several minutes in large deployments.Now the command will fail faster, allowing the user to adjust their command and retry.