Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for hvac read_secret_version parameter in Hashicorp Vault client #31347

Closed
2 tasks done
emredjan opened this issue May 17, 2023 · 0 comments · Fixed by #36532
Closed
2 tasks done
Assignees
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:hashicorp Hashicorp provider related issues

Comments

@emredjan
Copy link

Apache Airflow version

2.6.1

What happened

If you're using the Hashicorp Vault as your secrets backend, any calls to the functions in vault_client.py results in warnings like below in logs:

/data/apps/.pyenv/versions/3.10.4/envs/airflow-py310/lib/python3.10/site-packages/airflow/providers/hashicorp/_internal_client/vault_client.py:357 DeprecationWarning: The raise_on_delete
d parameter will change its default value to False in hvac v3.0.0. The current default of True will presere previous behavior. To use the old behavior with no warning, explicitly set this value to True. See https://github.com/hvac/h
vac/pull/907

This is because of a breaking change in the vault client hvac package, specifically in the read_secret_version function. A previously optional parameter raise_on_deleted_version, is now defaults to False, and should be explicitly set to True for keeping the previous behavior.

What you think should happen instead

There shouldn't be any deprecation warnings, parameter needs to be set explicitly.

How to reproduce

Setup hashicorp vault as the secrets backend
Run any airflow command that needs to access the secrets backend

Operating System

RHEL 8.5

Versions of Apache Airflow Providers

apache-airflow-providers-celery==3.1.0
apache-airflow-providers-common-sql==1.4.0
apache-airflow-providers-ftp==3.3.1
apache-airflow-providers-hashicorp==3.3.1
apache-airflow-providers-http==4.3.0
apache-airflow-providers-imap==3.1.1
apache-airflow-providers-microsoft-mssql==3.3.2
apache-airflow-providers-mysql==5.0.0
apache-airflow-providers-odbc==3.2.1
apache-airflow-providers-sftp==4.2.4
apache-airflow-providers-sqlite==3.3.2
apache-airflow-providers-ssh==3.6.0

Deployment

Virtualenv installation

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@emredjan emredjan added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels May 17, 2023
@hussein-awala hussein-awala added area:providers kind:task A task that needs to be completed as part of a larger issue provider:hashicorp Hashicorp provider related issues and removed kind:bug This is a clearly a bug area:core needs-triage label for new issues that we didn't triage yet labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue provider:hashicorp Hashicorp provider related issues
Projects
None yet
3 participants