Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator #36532

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator #36532

merged 3 commits into from
Jan 10, 2024

Conversation

romsharon98
Copy link
Contributor

closes: #31347

Unfortunately I don't have Hashicorp infrastructure to connect to it so I cannot check this.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@romsharon98 romsharon98 changed the title explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator Jan 2, 2024
@romsharon98 romsharon98 changed the title Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator Explicitly passing raise_on_deleted_version=True to read_secret_version in Hashicorp operator Jan 2, 2024
hussein-awala
hussein-awala requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check #31349 (review)?

@romsharon98
Copy link
Contributor Author

Could you check #31349 (review)?

Thanks for notice it @hussein-awala !
I didn't notice this thread :)
I decided to update hvac version like your suggestion.

hussein-awala
hussein-awala approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @potiuk started bumping the min version of different 3rd party libs (for ex: #36698), I don't see any problem with merging this PR.

@hussein-awala hussein-awala merged commit cd5ab08 into apache:main Jan 10, 2024
74 checks passed
@Taragolis Taragolis mentioned this pull request Jan 13, 2024
Merged
@potiuk potiuk added this to the Airflow 2.8.1 milestone Jan 13, 2024
@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2024
potiuk pushed a commit that referenced this pull request Jan 13, 2024
@romsharon98 @potiuk
Explicitly passing raise_on_deleted_version=True to `read_secret_ve…
2ca6d8e 
…rsion` in Hashicorp operator (#36532)

* explicitly passing raise_on_deleted_version=True to read_secret_version

* fix tests

* update hvac version

(cherry picked from commit cd5ab08)
ephraimbuddy pushed a commit that referenced this pull request Jan 15, 2024
@romsharon98 @ephraimbuddy
Explicitly passing raise_on_deleted_version=True to `read_secret_ve…
cde72b6 
…rsion` in Hashicorp operator (#36532)

* explicitly passing raise_on_deleted_version=True to read_secret_version

* fix tests

* update hvac version

(cherry picked from commit cd5ab08)
@eladkal eladkal mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussein-awala hussein-awala hussein-awala approved these changes

Assignees
No one assigned
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Milestone
Airflow 2.8.1
Development

Successfully merging this pull request may close these issues.

Deprecation warning for hvac read_secret_version parameter in Hashicorp Vault client
3 participants
@romsharon98 @hussein-awala @potiuk