Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default_webserver_config.py isn't compatible with the latest changes #36702

Closed
1 of 2 tasks
zachliu opened this issue Jan 9, 2024 · 5 comments · Fixed by #36719
Closed
1 of 2 tasks

default_webserver_config.py isn't compatible with the latest changes #36702

zachliu opened this issue Jan 9, 2024 · 5 comments · Fixed by #36719
Labels
affected_version:2.8 Issues Reported for 2.8 area:core area:webserver Webserver related Issues kind:bug This is a clearly a bug

Comments

@zachliu
Copy link
Contributor

zachliu commented Jan 9, 2024

Apache Airflow version

2.8.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

default_webserver_config.py
is not compatible with 2.8.X versions due to #35572

specifically, these imports are not valid anymore

# from airflow.www.fab_security.manager import AUTH_LDAP
# from airflow.www.fab_security.manager import AUTH_OAUTH
# from airflow.www.fab_security.manager import AUTH_OID
# from airflow.www.fab_security.manager import AUTH_REMOTE_USER

they should be

# from airflow.auth.managers.fab.security_manager.override import AUTH_LDAP
# from airflow.auth.managers.fab.security_manager.override import AUTH_OAUTH
# from airflow.auth.managers.fab.security_manager.override import AUTH_OID
# from airflow.auth.managers.fab.security_manager.override import AUTH_REMOTE_USER

What you think should happen instead?

No response

How to reproduce

for oauth users just keep using the old webserver_config.py

from airflow.www.fab_security.manager import AUTH_OAUTH

will cause

ImportError: cannot import name 'AUTH_OAUTH' from 'airflow.www.fab_security.manager' (/home/zach/KeplerGroup/KIP-Airflow/.venv/lib/python3.11/site-packages/airflow/www/fab_security/manager.py)

Operating System

Debian GNU/Linux 10 (buster)

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zachliu zachliu added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jan 9, 2024
@potiuk
Copy link
Member

potiuk commented Jan 10, 2024

cc: @vincbeck

@vincbeck
Copy link
Contributor

It should have been fixed in #35302

@vincbeck
Copy link
Contributor

Oh, some are missing, let me add them

@vincbeck vincbeck removed the needs-triage label for new issues that we didn't triage yet label Jan 10, 2024
@vincbeck
Copy link
Contributor

See fix: #36719

@vincbeck
Copy link
Contributor

You might want to add the fix to 2.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.8 Issues Reported for 2.8 area:core area:webserver Webserver related Issues kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants