Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow 2.8.1rc1 #36808

Closed
34 of 68 tasks
ephraimbuddy opened this issue Jan 16, 2024 · 18 comments
Closed
34 of 68 tasks

Status of testing of Apache Airflow 2.8.1rc1 #36808

ephraimbuddy opened this issue Jan 16, 2024 · 18 comments
Labels
kind:meta High-level information important to the community

Comments

@ephraimbuddy
Copy link
Contributor

ephraimbuddy commented Jan 16, 2024

Body

We are kindly requesting that contributors to Apache Airflow RC 2.8.1rc1 help test the RC.

Please let us know by commenting if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@joaopamaral @Lee-W @hussein-awala @amoghrajesh @fuatcakici @zachliu @llamageddon83 @dirrao @avkirilishin @uranusjr @dolfinus @yo1956 @ephraimbuddy @internetcoffeephone @BobDu @romsharon98 @Kache @kaxil @timonviola @potiuk @pateash @babinos87 @shohamy7 @tullis @HurSungYun @raphaelauv @ant-bl @csp33 @Taragolis @evgenyslab @joshowen @dstandish @noamcohen97 @ardubev16 @eliskovets @crabio @jscheffl @alephmelo @kacpermuda @vchiapaikeo @vincbeck

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@ephraimbuddy ephraimbuddy added the kind:meta High-level information important to the community label Jan 16, 2024
@BobDu
Copy link
Contributor

BobDu commented Jan 16, 2024

sorry, where can i pull airflow 2.8.1rc1 docker image?
not found in dockerhub

https://hub.docker.com/r/apache/airflow/tags?page=1&name=2.8.1rc1

@ephraimbuddy
Copy link
Contributor Author

sorry, where can i pull airflow 2.8.1rc1 docker image? not found in dockerhub

https://hub.docker.com/r/apache/airflow/tags?page=1&name=2.8.1rc1

Sorry, I created this before the images were done pushing. Can you try again

@BobDu
Copy link
Contributor

BobDu commented Jan 16, 2024

#36275 #36750 #36787 working as expected.

image image

@amoghrajesh
Copy link
Contributor

Just checked my changes:

Both of these work as expected 🚢

@Taragolis
Copy link
Contributor

Taragolis commented Jan 16, 2024

Validate all non slim X86_64 images, the command python -c 'import MySQLdb; print("OK")' do not throw any error

In addition validate custom docker build from the tag without specifying INSTALL_MYSQL_CLIENT_TYPE build arg, everything works fine

git checkout 2.8.1rc1
Note: switching to '2.8.1rc1'.docker build . \
    --build-arg DOCKER_CONTEXT_FILES=./docker-context-files \
    --build-arg INSTALL_MYSQL_CLIENT="true" \
    --build-arg INSTALL_MSSQL_CLIENT="true" \
    --build-arg INSTALL_POSTGRES_CLIENT="true" \
    --tag "airflow-image:latest"
[+] Building 171.4s (68/68) FINISHED                                                                                                           docker:defaultdocker run -it --rm airflow-image:latest bash

airflow@ab694be6c26d:/opt/airflow$ apt list *maria*
Listing... Done
libmariadb3-compat/now 1:10.11.6+maria~deb12 amd64 [installed,local]
libmariadb3/now 1:10.11.6+maria~deb12 amd64 [installed,local]
mariadb-client-core/now 1:10.11.6+maria~deb12 amd64 [installed,local]
mariadb-client/now 1:10.11.6+maria~deb12 amd64 [installed,local]
mariadb-common/now 1:10.11.6+maria~deb12 all [installed,local]

airflow@ab694be6c26d:/opt/airflow$ python -c 'import MySQLdb; print("OK")'
OK

Changes in tests, should not affect codebase

Taskflow's multiple_outputs

Tested, work as expected. No errors in case of Union typing annotation in Python 3.10+

Decorators typing annotations

Looks consistent to the latest docker and k8s providers

@teihenn
Copy link
Contributor

teihenn commented Jan 16, 2024

I checked my change:

It worked as expected.
If a request larger than the "allowed_payload_size" specified in airflow.cfg is sent to the webserver, it returns the error page: "Request Entity Too Large".

@joaopamaral
Copy link
Contributor

image
[2024-01-16, 13:55:20 UTC] {logging_mixin.py:188} INFO - Success callback triggered!
[2024-01-16, 13:55:20 UTC] {logging_mixin.py:188} INFO - Task Instance: [<TaskInstance: example_removed_task_dag.success_task scheduled__2024-01-15T00:00:00+00:00 [running]>, <TaskInstance: example_removed_task_dag.removed_task_2 scheduled__2024-01-15T00:00:00+00:00 [removed]>, <TaskInstance: example_removed_task_dag.removed_task scheduled__2024-01-15T00:00:00+00:00 [removed]>, <TaskInstance: example_removed_task_dag.failure_task scheduled__2024-01-15T00:00:00+00:00 [removed]>, <TaskInstance: example_removed_task_dag.start_task scheduled__2024-01-15T00:00:00+00:00 [removed]>, <TaskInstance: example_removed_task_dag.end_task scheduled__2024-01-15T00:00:00+00:00 [removed]>]

@csp33
Copy link
Contributor

csp33 commented Jan 16, 2024

image
All good with #36522

@potiuk
Copy link
Member

potiuk commented Jan 16, 2024

All my changes are in and good !

Particularly happy with that one:

airflow@e6cddae1d57a:/opt/airflow$ AIRFLOW_HOME=./test airflow db init
Traceback (most recent call last):
  File "/home/airflow/.local/bin/airflow", line 5, in <module>
    from airflow.__main__ import main
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/__init__.py", line 68, in <module>
    settings.initialize()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/settings.py", line 538, in initialize
    configure_vars()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/settings.py", line 198, in configure_vars
    raise AirflowConfigException(
airflow.exceptions.AirflowConfigException: Cannot use relative path: `sqlite:///./test/airflow.db` to connect to sqlite. Please use absolute path such as `sqlite:////tmp/airflow.db`.

@joshowen
Copy link
Contributor

I've confirmed fix datetime reference in DAG.is_fixed_time_schedule (#36370) is good.

@shohamy7
Copy link
Contributor

#36522 & #36616 looks good to me

@Taragolis
Copy link
Contributor

Check different component under pendulum 3 (default in constraints) and pendulum 2.1.2, can't find any noticeable side effects

@jscheffl
Copy link
Contributor

Validated #36509 and #36518 - all looks good!

@Lee-W
Copy link
Member

Lee-W commented Jan 18, 2024

I tried to test #36379, but it did not fix the issue as expected. I still need #36363 to get it to work properly. It did not break anything, either, so it won't be a blocker. @hussein-awala, do you have the chance to test it on your side as well?

@vchiapaikeo
Copy link
Contributor

#35536 and #36753 look good

@ephraimbuddy
Copy link
Contributor Author

Airflow 2.8.1 has been released. Thank you all for testing this release candidate

@gabrielbrittes
Copy link

All my changes are in and good !

Particularly happy with that one:

airflow@e6cddae1d57a:/opt/airflow$ AIRFLOW_HOME=./test airflow db init
Traceback (most recent call last):
  File "/home/airflow/.local/bin/airflow", line 5, in <module>
    from airflow.__main__ import main
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/__init__.py", line 68, in <module>
    settings.initialize()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/settings.py", line 538, in initialize
    configure_vars()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/settings.py", line 198, in configure_vars
    raise AirflowConfigException(
Please use absolute path such as sqlite:////tmp/airflow.db

hello! have you goes still facing something like that? i'm using windows 10.

[]'s

@potiuk
Copy link
Member

potiuk commented Jan 26, 2024

hello! have you goes still facing something like that? i'm using windows 10.

Yes. Because You need to use WSL2 if you want to run Airflow on Eindows. Read prerequisites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community
Projects
None yet
Development

No branches or pull requests