-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError while using the function update_state #36712
Conversation
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway. Co-authored-by: fuat.cakici <fuat.cakici@knab.nl> (cherry picked from commit dfa695a)
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway. Co-authored-by: fuat.cakici <fuat.cakici@knab.nl> (cherry picked from commit dfa695a)
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.
Fixes #34604
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.