Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError while using the function update_state #36712

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix AttributeError while using the function update_state #36712

merged 1 commit into from
Jan 10, 2024

Conversation

fuatcakici
Copy link
Contributor

The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.

Fixes #34604


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.
Copy link

boring-cyborg bot commented Jan 10, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dirrao dirrao added area:core kind:bug This is a clearly a bug labels Jan 10, 2024
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladkal eladkal changed the title Remove dot value Fix AttributeError while using the function update_state Jan 10, 2024
@eladkal eladkal added this to the Airflow 2.8.1 milestone Jan 10, 2024
@eladkal eladkal added type:bug-fix Changelog: Bug Fixes and removed kind:bug This is a clearly a bug labels Jan 10, 2024
@potiuk potiuk merged commit dfa695a into apache:main Jan 10, 2024
53 checks passed
Copy link

boring-cyborg bot commented Jan 10, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Jan 11, 2024
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.

Co-authored-by: fuat.cakici <fuat.cakici@knab.nl>
(cherry picked from commit dfa695a)
ephraimbuddy pushed a commit that referenced this pull request Jan 15, 2024
The update_state function in the DagRun class fails as ever since an update was made to Airflow, the state of the DagRun is returned as a string instead of an actual DagRunState. However, should this be fixed in the future, this change would still not affect anything since the state is called as a string here, which would return the value without needing to specify ".value" anyway.

Co-authored-by: fuat.cakici <fuat.cakici@knab.nl>
(cherry picked from commit dfa695a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError while using the function update_state
4 participants