Fix get_leaves calculation for teardown in nested group #36456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36345
When arrowing
group
>>task
, the "leaves" ofgroup
are connected totask
. When calculating leaves in the group, teardown tasks are ignored, and we recurse upstream to find non-teardowns.What was happening, and what this fixes, is you might recurse to a work task that already has another non-teardown downstream in the group. In that case you should ignore the work task (because it already has a non-teardown descendent).
Before:
After:
Code: