Add securitySchemes in openapi spec #10652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only affects documentation for go clients, but for some other languages like typescript and java, it is used a feature gate to generate the actual client code. The go client documentation right now is not generated correctly, which will be fixed by OpenAPITools/openapi-generator#7312. |
mik-laj
reviewed
Aug 31, 2020
|
New sections have appeared in the reference documentation. I think it's worth hiding them because we have other documentation that is more precise. |
mik-laj
reviewed
Aug 31, 2020
added 2 commits
August 31, 2020 18:17
openapi-generator relies on this component to generate auth code in some of the clients.
houqp
force-pushed
the
qp/securityschemes
branch
from
c56025d to
22073f4
Compare
|
@jhtimmins Can I ask for a review? |
jhtimmins
reviewed
Sep 4, 2020
| @@ -553,6 +553,7 @@ def _get_rst_filepath_from_path(filepath: str): | |||
| 'spec': OPENAPI_FILE, | |||
| 'opts': { | |||
| 'hide-hostname': True, | |||
| 'no-auto-auth': True, | |||
There was a problem hiding this comment.
What is no-auto-auth used for?
mik-laj
approved these changes
Sep 4, 2020
mik-laj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openapi-generator relies on this component to generate auth code in
some of the clients.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.