Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: remove -serviceaccount suffix from KSA names in helm chart #10892

Merged
merged 9 commits into from
Sep 15, 2020
Merged

Proposal: remove -serviceaccount suffix from KSA names in helm chart #10892

merged 9 commits into from
Sep 15, 2020

Commits on Sep 12, 2020

  1. [WIP] remove -serviceaccount suffix in helm chart 

    It's quite annoying to have `-serviceaccount` in each service account name as this is a useless 15 characters that provides no additional information.
"why is this so frustrating to you Jake?"
GCP service accounts have 30 char name limit https://cloud.google.com/iam/docs/creating-managing-service-accounts#creating
For manageability / clarity I'd like to keep KSA and GSA names exactly the same when using workload identity which maps KSA<>GSA 1:1 https://cloud.google.com/kubernetes-engine/docs/how-to/workload-identity.
    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    a2b630f View commit details
    Browse the repository at this point in the history

  2. Update cleanup-serviceaccount.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    680256c View commit details
    Browse the repository at this point in the history

  3. Update scheduler-serviceaccount.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    002ed28 View commit details
    Browse the repository at this point in the history

  4. Update worker-serviceaccount.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    f350159 View commit details
    Browse the repository at this point in the history

  5. Update pod-cleanup-rolebinding.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    6d16ff0 View commit details
    Browse the repository at this point in the history

  6. Update cleanup-cronjob.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    eac380f View commit details
    Browse the repository at this point in the history

  7. Update pod-template-file.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    c39578e View commit details
    Browse the repository at this point in the history

  8. Update worker-deployment.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    a5f39bc View commit details
    Browse the repository at this point in the history

  9. Update scheduler-deployment.yaml

    Jacob Ferriero committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    7c576e6 View commit details
    Browse the repository at this point in the history