Format all files (without excepions) by black #12091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
k8s
provider:google
mik-laj
commented
Nov 4, 2020
airflow/configuration.py
Outdated
| 'SequentialExecutor', | ||
| ) | ||
| is_sqlite = "sqlite" in self.get('core', 'sql_alchemy_conn') | ||
| if is_executor_without_sqlie_support and is_sqlite: |
There was a problem hiding this comment.
This piece of code couldn't handle black, so I wrote it a bit differently.
mik-laj
commented
Nov 4, 2020
| tempfile.TemporaryDirectory() as gcloud_config_tmp, \ | ||
| patch_environ({'CLOUDSDK_CONFIG': gcloud_config_tmp}): | ||
| with ExitStack() as exit_stack: | ||
| exit_stack.enter_context(self.provide_gcp_credential_file_as_context()) |
There was a problem hiding this comment.
This piece of code couldn't handle black, so I wrote it a bit differently.
mik-laj
commented
Nov 4, 2020
| priority_class_name: Optional[str] = None, | ||
| termination_grace_period: Optional[int] = None, | ||
| **kwargs) -> None: | ||
| def __init__( # pylint: disable=too-many-arguments,too-many-locals |
There was a problem hiding this comment.
Black moved the comment down one line so I had to turn off the formatting.
kaxil
reviewed
Nov 4, 2020
airflow/configuration.py
Outdated
| if ( | ||
| self.get("core", "executor") not in ('DebugExecutor', 'SequentialExecutor') and | ||
| "sqlite" in self.get('core', 'sql_alchemy_conn')): | ||
| is_executor_without_sqlie_support = self.get("core", "executor") not in ( |
There was a problem hiding this comment.
Suggested change
| is_executor_without_sqlie_support = self.get("core", "executor") not in ( | |
| is_executor_without_sqlite_support = self.get("core", "executor") not in ( |
kaxil
reviewed
Nov 4, 2020
airflow/configuration.py
Outdated
| 'SequentialExecutor', | ||
| ) | ||
| is_sqlite = "sqlite" in self.get('core', 'sql_alchemy_conn') | ||
| if is_executor_without_sqlie_support and is_sqlite: |
There was a problem hiding this comment.
Suggested change
| if is_executor_without_sqlie_support and is_sqlite: | |
| if is_executor_without_sqlite_support and is_sqlite: |
kaxil
reviewed
Nov 4, 2020
airflow/configuration.py
Outdated
|
|
||
| raise AirflowConfigException( | ||
| "section/key [{section}/{key}] not found " | ||
| "in config".format(section=section, key=key)) | ||
| "section/key [{section}/{key}] not found " "in config".format(section=section, key=key) |
There was a problem hiding this comment.
Suggested change
| "section/key [{section}/{key}] not found " "in config".format(section=section, key=key) | |
| "section/key [{section}/{key}] not found in config".format(section=section, key=key) |
turbaszek
reviewed
Nov 4, 2020
airflow/configuration.py
Outdated
|
|
||
| if process.returncode != 0: | ||
| raise AirflowConfigException( | ||
| "Cannot execute {}. Error code is: {}. Output: {}, Stderr: {}" | ||
| .format(command, process.returncode, output, stderr) | ||
| "Cannot execute {}. Error code is: {}. Output: {}, Stderr: {}".format( |
kaxil
approved these changes
Nov 4, 2020
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
ashb
approved these changes
Nov 4, 2020
turbaszek
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: 4a5ce39#r517012913
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.