Migrate all packages to use PEP 517 #16144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests will show. All the build commands (including building providers) are executed in CI :) |
uranusjr
force-pushed
the
pep-517
branch
8 times, most recently
from
853822c to
589711b
Compare
Since we need to run things before building a dist (namely compile_assets and build-tagging), a custom PEP 517 backend is created to do them instead of standalone setup.py commands in the shell script.
This make the pyproject.toml distinct from the parent airflow package since they now have different build dependencies. A custom build backend is also created to handle build tagging.
|
Things seem to work...? |
|
Since |
|
This seems to break editable install. Need more investigation. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main Airflow and all provider packages are now using
pyproject.toml's[build-system]to specify build-time requirements, and use https://github.com/pypa/build to build sdist and wheel.TBH I kind of lost track half way of what I should change in the build system. I don't have much confidence of some changes I've made.
cc @potiuk
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.