Fix race condition with dagrun callbacks #16741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
jedcunningham
force-pushed
the
dagrun_callback
branch
from
ba1a248 to
29f1f89
Compare
|
(still needs more test coverage I think, but would like to get a preliminary review before I spend more time on it) |
jedcunningham
force-pushed
the
dagrun_callback
branch
from
f202756 to
acacc9a
Compare
kaxil
approved these changes
Jul 11, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
reviewed
Jul 11, 2021
uranusjr
reviewed
Jul 14, 2021
jedcunningham
force-pushed
the
dagrun_callback
branch
2 times, most recently
from
80d78eb to
6fb17d8
Compare
kaxil
approved these changes
Jul 26, 2021
jedcunningham
force-pushed
the
dagrun_callback
branch
from
6fb17d8 to
f3e2ae5
Compare
uranusjr
approved these changes
Jul 28, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs.
jedcunningham
force-pushed
the
dagrun_callback
branch
from
f3e2ae5 to
47d3350
Compare
|
Merged, failures are flacky tests. |
jhtimmins
pushed a commit
that referenced
this pull request
Aug 11, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
kaxil
pushed a commit
that referenced
this pull request
Aug 13, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
kaxil
pushed a commit
that referenced
this pull request
Aug 13, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
kaxil
pushed a commit
that referenced
this pull request
Aug 14, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
Instead of immediately sending callbacks to be processed, wait until after we commit so the dagrun.end_date is guaranteed to be there when the callback runs. (cherry picked from commit fb3031a)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of immediately sending callbacks to be processed, wait until
after we commit so the dagrun.end_date is guaranteed to be there when
the callback runs.