-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear task's next_method and next_kwargs when clear the task #19640
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
It seems stuck at Tests/ Wait for CI images(pull_request), What can I do now? |
Let it try again |
I merged the latest upstream |
There are some failing checks which caused by AssertionError.
I check the error info, is the dagrun_execution_dates list missing some elements?I have no idea what goes wrong here. |
@@ -204,6 +204,7 @@ def clear_task_instances( | |||
ti.max_tries = max(ti.max_tries, ti.prev_attempted_tries) | |||
ti.state = State.NONE | |||
ti.external_executor_id = None | |||
ti.clear_next_method_args() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some sort of unit test for it?
suggestions @uranusjr @dstandish ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional asserts in TestClearTasks
should be good enough.
The description says this closes #19120 but that issue is already closed. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Can I reopen this PR or start a new PR for it ? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
clear task's next_method and next_kwargs when clear the task
closes: #19120
related: #19612