Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autodetect arg to Create External Table Operator #22202

Closed
wants to merge 3 commits into from

Conversation

shahkshitij15
Copy link
Contributor

@shahkshitij15 shahkshitij15 commented Mar 12, 2022

closes: #22129

Added autodetect argument to BigQueryCreateExternalTable Operator

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 12, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 13, 2022
Copy link
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please make sure that this change is covered in tests?

@eladkal
Copy link
Contributor

eladkal commented Mar 20, 2022

@shahkshitij15 can you please fix failing test?
https://github.com/apache/airflow/runs/5612449295?check_suite_focus=true#step:9:3155

 ==================================== ERRORS ====================================
  _ ERROR collecting tests/providers/google/firebase/operators/test_firestore_system.py _
  tests/providers/google/firebase/operators/test_firestore_system.py:20: in <module>
      from airflow.providers.google.firebase.example_dags.example_firestore import (
  airflow/providers/google/firebase/example_dags/example_firestore.py:119: in <module>
      "csvOptions": {"skipLeadingRows": 1},
  airflow/models/baseoperator.py:386: in apply_defaults
      result = func(self, **kwargs, default_args=default_args)
  airflow/providers/google/cloud/operators/bigquery.py:1111: in __init__
      raise ValueError("You provided both `table_resource` and exclusive keywords arguments.")
  E   ValueError: You provided both `table_resource` and exclusive keywords arguments.
  =============================== warnings summary ===============================

@eladkal
Copy link
Contributor

eladkal commented Apr 28, 2022

fixed in #22710

@eladkal eladkal closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add autodetect arg in BQCreateExternalTable Operator
4 participants