-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally not follow logs in KPO pod_manager #22412
Conversation
When writing an async KPO, you want to be able to read logs up to the current moment and exit (i.e. and not follow the logs). Additionally you want to be able to resume from a particular moment in time. That's what this PR enables.
Overall looks good, no test coverage though? |
added some coverage there. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Tests are failing 😞 |
|
thanks, will fix |
@kaxil |
When writing an async KPO, you want to be able to read logs up to the current moment and exit (i.e. and not follow the logs). Additionally you want to be able to resume from a particular moment in time. That's what this PR enables.