-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass X-Presto-Client-Info in presto hook #22416
Conversation
bd2552a
to
4ce86ea
Compare
@potiuk any suggestions that I can fix this https://github.com/apache/airflow/runs/5648830794?check_suite_focus=true#step:11:1039 since there is not
|
Jus don't import it from there. or catch an import and provide a suitable default. I do not know the history of DEFAULT_FORMAT_PREFIX so cannot give a definite answer, but definitely if you add this import - you are relying on 2.3 behaviour, which we should not do. |
Seems that it's you who added the prefix, so you should know what to use in the provider to make it 2.1 comatible I think :) |
Seems that the prefix was actually added in 2.3 so you MUST make it compatible because 2.2 compatibility will be there for quite a while. The 2.2 compatibility is there till October 11. |
4ce86ea
to
0fb6628
Compare
f77da57
to
6ff570f
Compare
6ff570f
to
9d18ed9
Compare
@pingzh Should we do that also for TrinoHook? |
@eladkal good catch. let me add that as well. |
so that in the presto side, it can track back to an airflow task, according to this doc https://prestodb.io/docs/current/develop/client-protocol.html
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.