Stop crashing when empty logs are received from kubernetes client #22566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
potiuk
force-pushed
the
fix-crashing-kpo-on-empty-log
branch
from
57940bc to
d2f7051
Compare
It seems that in some circumstances, the K8S client might return empty logs even if "timestamps" options is specified. That should not happen in general, but apparently it does in some cases and leads to task being killed. Rather than killing the tasks we should log it as an error (on top of trying to find out why and preventing it from happening - also to be able to gather more information and diagnosis on when it happens). Related to: apache#21605
potiuk
force-pushed
the
fix-crashing-kpo-on-empty-log
branch
from
d2f7051 to
1e7c73e
Compare
dstandish
approved these changes
Mar 28, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
2 tasks
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some circumstances, the K8S client might return
empty logs even if "timestamps" options is specified.
That should not happen in general, but apparently it does in
some cases and leads to task being killed.
Rather than killing the tasks we should log it as an error
(on top of trying to find out why and preventing it from
happening - also to be able to gather more information and
diagnosis on when it happens).
Related to: #21605
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.